Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (kustomize/v2, go/v4): fix role and kustomize build when no CRDs are added to the project #3627

Merged
merged 1 commit into from
Oct 2, 2023
Merged

🐛 (kustomize/v2, go/v4): fix role and kustomize build when no CRDs are added to the project #3627

merged 1 commit into from
Oct 2, 2023

Conversation

camilamacedo86
Copy link
Member

Description

A project might have no CRDs generate their for:

  • We should scaffold the project with the config/default/kustomization.yaml with crd commented when we run init
  • We should generate the basic Role since controller-gen is only able to do that when markers are found in the controllers
  • We should uncomment the crd config from config/default/kustomization.yaml when api is generated.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2023
@camilamacedo86 camilamacedo86 changed the title 🐛 fix role and kustomize build when no CRDs are added to the project 🐛 (kustomize/v2, go/v4): fix role and kustomize build when no CRDs are added to the project Sep 17, 2023
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 17, 2023
Merged
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-26-6

@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-27-3

varshaprasad96
varshaprasad96 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

docs/book/src/component-config-tutorial/testdata/project/config/rbac/role.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a8204fa into kubernetes-sigs:master Oct 2, 2023
@Neo2308 Neo2308 mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

Assignees

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilamacedo86 @k8s-ci-robot @varshaprasad96