Skip to content

Migrate to ginkgo v2 #2875

Closed
Closed
@jakobmoellerdev

Description

@jakobmoellerdev

What do you want to happen?

With the Migration of Gingko in controller-runtime (see kubernetes-sigs/controller-runtime#1977) we will also have the chance to migrate our test coding as well as our templated scaffolds to gingko v2. To make sure that we do not break incompatibility, we especially need to look at the migration guide in https://onsi.github.io/ginkgo/MIGRATING_TO_V2

Since CR is upgrading this also means we have to react to the resulting breaking changes
EDIT: This is not a breaking change anymore after the removal of the changes of the printer package

The PR removes two helpers in pkg/envtest/printer that were used with ginkgo v1. Since you can't use both versions at the same time, this isn't relevant though.
In summary, all projects depending on controller-runtime will have to update to ginkgo v2 after this is merged and released. Upstream did so already: kubernetes/kubernetes#109111

Extra Labels

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions