Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ginkgo v2 #2875

Closed
jakobmoellerdev opened this issue Aug 15, 2022 · 2 comments
Closed

Migrate to ginkgo v2 #2875

jakobmoellerdev opened this issue Aug 15, 2022 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jakobmoellerdev
Copy link
Contributor

jakobmoellerdev commented Aug 15, 2022

What do you want to happen?

With the Migration of Gingko in controller-runtime (see kubernetes-sigs/controller-runtime#1977) we will also have the chance to migrate our test coding as well as our templated scaffolds to gingko v2. To make sure that we do not break incompatibility, we especially need to look at the migration guide in https://onsi.github.io/ginkgo/MIGRATING_TO_V2

Since CR is upgrading this also means we have to react to the resulting breaking changes
EDIT: This is not a breaking change anymore after the removal of the changes of the printer package

The PR removes two helpers in pkg/envtest/printer that were used with ginkgo v1. Since you can't use both versions at the same time, this isn't relevant though.
In summary, all projects depending on controller-runtime will have to update to ginkgo v2 after this is merged and released. Upstream did so already: kubernetes/kubernetes#109111

Extra Labels

No response

@jakobmoellerdev
Copy link
Contributor Author

Duplicate of #2532 @camilamacedo86 which one should we leave open?

@camilamacedo86
Copy link
Member

camilamacedo86 commented Aug 16, 2022

We can close this one in favour of #2532
@jakobmoellersap also I think we can check what also needs to be done in #2522 and would be nice to add this contributor as co-author to also give the credit to him.

Closing this one and adding the info on why we will meed to move forward with it for v3 and project as well there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants