Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update go version to 1.15 and tidy up modules #32

Merged
merged 1 commit into from
May 20, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Jan 15, 2021

Background

regexp.Regexp.SubexpIndex was added in 1.15 and despite using that method, go.mod still is in 1.14:

minorRaw := parts[releaseRE.SubexpIndex("minor")]
majorRaw := parts[releaseRE.SubexpIndex("major")]

go-git is not being used but it still figures in go.mod:

github.com/go-git/go-git/v5 v5.1.0

Description

This PR updates the go version in go.mod and tidies the modules to remove go-git.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2021
@Adirio Adirio changed the title Update go version to 1.15 and tidy up modules 🌱 Update go version to 1.15 and tidy up modules Jan 15, 2021
Signed-off-by: Adrian Orive Oneca <adrian.orive.oneca@gmail.com>
@Adirio Adirio changed the title 🌱 Update go version to 1.15 and tidy up modules 🐛 Update go version to 1.15 and tidy up modules Feb 18, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows great for me 🥇 .

However, I since I have not further knowledge in the kubebuilder-release-tools (I never push a PR and etc for this one), I think is good +1 person checkout as well.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2021
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @DirectXMan12

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c766ea3 into kubernetes-sigs:master May 20, 2021
@Adirio Adirio deleted the update-go-version branch May 23, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants