-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update go version to 1.15 and tidy up modules #32
Conversation
Signed-off-by: Adrian Orive Oneca <adrian.orive.oneca@gmail.com>
9546259
to
bdfa6e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shows great for me 🥇 .
However, I since I have not further knowledge in the kubebuilder-release-tools (I never push a PR and etc for this one), I think is good +1 person checkout as well.
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @DirectXMan12
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Background
regexp.Regexp.SubexpIndex
was added in 1.15 and despite using that method,go.mod
still is in 1.14:kubebuilder-release-tools/notes/go.mod
Line 3 in 7259830
kubebuilder-release-tools/notes/compose/notes.go
Lines 45 to 46 in 7259830
go-git
is not being used but it still figures ingo.mod
:kubebuilder-release-tools/notes/go.mod
Line 7 in 7259830
Description
This PR updates the go version in
go.mod
and tidies the modules to removego-git
.