Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update RELEASE.md to specify googlegroup and project name #16

Merged
merged 1 commit into from
Nov 23, 2020
Merged

📖 Update RELEASE.md to specify googlegroup and project name #16

merged 1 commit into from
Nov 23, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 18, 2020

Description

Update the RELEASE.md file to:

  • Update google group to the kubebuilder one as notifying kubernetes-dev about a new release of a release-tool for kubebuilder sounds like an overkill and even can be considered spam.
  • Update the project name

Motivation

Clarify release process.

@Adirio
Update RELEASE.md to specify googlegroup and project name
80b9582 
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2020
@Adirio Adirio changed the title Update RELEASE.md to specify googlegroup and project name 🌱 Update RELEASE.md to specify googlegroup and project name Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2020
@Adirio Adirio changed the title 🌱 Update RELEASE.md to specify googlegroup and project name 📖 Update RELEASE.md to specify googlegroup and project name Nov 18, 2020
camilamacedo86
camilamacedo86 approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows ok for me 👍

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
camilamacedo86
camilamacedo86 reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 97c62fb into kubernetes-sigs:master Nov 23, 2020
@Adirio Adirio deleted the release-md branch November 23, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adirio @k8s-ci-robot @camilamacedo86