Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the component config #245

Closed
sanposhiho opened this issue Oct 24, 2022 · 3 comments · Fixed by #249
Closed

Create the component config #245

sanposhiho opened this issue Oct 24, 2022 · 3 comments · Fixed by #249
Assignees
@yanghesong
Labels
area/simulator Issues or PRs related to the simulator. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@sanposhiho
Copy link
Member

/kind feature
/kind cleanup
/area simulator

Currently, the simulator is configured via environment variables.
https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/env-variables.md

I'd like to create the component config to configure the simulator and deprecate those envs in the future.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/simulator Issues or PRs related to the simulator. labels Oct 24, 2022
@yanghesong
Copy link
Member

/assign

@yanghesong yanghesong mentioned this issue Nov 8, 2022
Closed
9 tasks
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Nov 13, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
f26e64b 
Create the component config in simulator.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Nov 14, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
a129606 
Create the component config in simulator.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
@yanghesong yanghesong mentioned this issue Nov 14, 2022
Merged
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Nov 16, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
d3b3cbf 
Create the component config in simulator.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Nov 17, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
3d1daed 
Add deprecated in the doc.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Dec 6, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
983fbbd 
Add code-generator code of config.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Dec 6, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
63b0eea 
Fit config to code-generator.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Dec 6, 2022
@yanghesong
Create the component config.(kubernetes-sigs#245)
ba0f454 
Fit config to code-generator.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
@yanghesong yanghesong mentioned this issue Dec 15, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@sanposhiho
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

Still important. Will be implemented by #249

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2023
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Mar 9, 2023
@yanghesong
Create the component config.(kubernetes-sigs#245)
40944a3 
Add deprecated in the doc.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Mar 9, 2023
@yanghesong
Create the component config.(kubernetes-sigs#245)
7baf5f7 
Add code-generator code of config.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Mar 9, 2023
@yanghesong
Create the component config.(kubernetes-sigs#245)
2596ad7 
Add config component.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
yanghesong added a commit to yanghesong/kube-scheduler-simulator that referenced this issue Mar 9, 2023
@yanghesong
Create the component config.(kubernetes-sigs#245)
afa9262 
Add documentation and examples.

Signed-off-by: yanghesong <hesong.yang@foxmail.com>
k8s-ci-robot added a commit that referenced this issue Mar 18, 2023
@k8s-ci-robot
Merge pull request #249 from yanghesong/Load_config_from_config_file_…
7a81634 
…for_simulator

Create the component config for simulator.(#245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanghesong yanghesong

Labels
area/simulator Issues or PRs related to the simulator. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create the component config for simulator.(#245) yanghesong/kube-scheduler-simulator
4 participants
@k8s-ci-robot @sanposhiho @k8s-triage-robot @yanghesong