Fixing search results

[wallentx]

Fixes #862

I'm not really sure what might could be added to the tests to account for this.

[k8s-ci-robot]

Welcome @wallentx!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[chriskim06]

we should probably add a test case here https://github.com/kubernetes-sigs/krew/blob/master/cmd/krew/cmd/search_test.go#L31-L62 with an empty keyword expecting the full set of names. this bug has probably been in krew for some time

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, wallentx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wallentx]

we should probably add a test case here https://github.com/kubernetes-sigs/krew/blob/master/cmd/krew/cmd/search_test.go#L31-L62 with an empty keyword expecting the full set of names. this bug has probably been in krew for some time

I've made the requested changes to the search_test 👍

[chriskim06]

actually looking into it a bit more, we have this integration test https://github.com/kubernetes-sigs/krew/blob/master/integration_test/search_test.go#L24-L34 but it didnt catch this because it just checks that there are at least 10 lines in the output. wonder if we should update this to an exact number (1 + number of plugins in the cloned index; the 1 being the header line in the search output).

[wallentx]

@chriskim06 I've got Allow edits and access to secrets by maintainers checked, so feel free to do whatever you deem is most appropriate.

[chriskim06]

ill update the integration test in a follow up pr later today. thanks for catching this and fixing!

/lgtm