Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error when checking whether comment is supported #5

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix syntax error when checking whether comment is supported #5

merged 1 commit into from
Feb 5, 2024

Conversation

tnqn
Copy link
Contributor

@tnqn tnqn commented Feb 4, 2024

The check failed with "Error: syntax error, unexpected '}', expecting newline or semicolon" even when comment is supported.

@k8s-ci-robot k8s-ci-robot requested a review from aojea February 4, 2024 14:55
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tnqn!

It looks like this is your first PR to kubernetes-sigs/knftables 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/knftables has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2024
danwinship
danwinship reviewed Feb 4, 2024
View reviewed changes
nftables.go Outdated
@@ -105,7 +105,7 @@ func newInternal(family Family, table string, execer execer) (Interface, error)
// Check that (a) nft works, (b) we have permission, (c) the kernel is new enough
// to support object comments.
cmd = exec.Command(nft.path, "--check", "add", "table", string(nft.family), nft.table,
"{", "comment", `"test"`, "}",
"{", "comment", `"test"`, ";", "}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

We should rewrite this to use nft.Check now that that exists. Then that gets rid of the opportunity to get the syntax wrong...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tnqn tnqn force-pushed the fix-comment-check branch from 6291a6b to c6f2dcf Compare February 5, 2024 03:19
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2024
@tnqn
Fix syntax error when checking whether comment is supported
f2b1bd3 
The check failed with "Error: syntax error, unexpected '}', expecting
newline or semicolon" even when comment is supported.

Signed-off-by: Quan Tian <qtian@vmware.com>
@tnqn tnqn force-pushed the fix-comment-check branch from c6f2dcf to f2b1bd3 Compare February 5, 2024 03:21
@danwinship
Copy link
Collaborator

great catch. thanks
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, tnqn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2ae9d8b into kubernetes-sigs:master Feb 5, 2024
5 checks passed
@tnqn tnqn deleted the fix-comment-check branch February 5, 2024 16:09
@tnqn tnqn mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@aojea aojea Awaiting requested review from aojea

Assignees

@danwinship danwinship

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnqn @k8s-ci-robot @danwinship