Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flowtable object #18

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 28, 2024

@aojea aojea requested review from danwinship and npinaeva October 28, 2024 11:27
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 28, 2024

/hold

pending testing with kubernetes

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2024
@danwinship danwinship changed the title [RFC] add flowbtable object [RFC] add flowtable object Oct 28, 2024
fake.go Show resolved Hide resolved
fake.go Show resolved Hide resolved
nftables_test.go Outdated Show resolved Hide resolved
nftables_test.go Outdated Show resolved Hide resolved
objects.go Show resolved Hide resolved
objects.go Outdated Show resolved Hide resolved
objects.go Outdated Show resolved Hide resolved
objects.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
@aojea aojea changed the title [RFC] add flowtable object add flowtable object Oct 28, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 28, 2024

/hold cancel

addressed comments

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2024
@aojea
Copy link
Contributor Author

aojea commented Oct 29, 2024

@danwinship incorporated the patch you shared via slack that fixes the problems with the kube-proxy unit tests kubernetes/kubernetes#128392 (it fails only the test that expect certain number of transactions now, but since we are going to make the feature opt-in I will not modify the tests now, just we know this has been fixed)

The other problem was in the regex to get the list of devices between the curly brackets, now I just copied from your logic for the comments, it gets everything inside the curly brackets and trims the spaces

This now is ready to go

@danwinship
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit d048b18 into kubernetes-sigs:master Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants