-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flowtable object #18
Conversation
/hold pending testing with kubernetes |
/hold cancel addressed comments |
Add flowtable object based on https://www.netfilter.org/projects/nftables/manpage.html
@danwinship incorporated the patch you shared via slack that fixes the problems with the kube-proxy unit tests kubernetes/kubernetes#128392 (it fails only the test that expect certain number of transactions now, but since we are going to make the feature opt-in I will not modify the tests now, just we know this has been fixed) The other problem was in the regex to get the list of devices between the curly brackets, now I just copied from your logic for the comments, it gets everything inside the curly brackets and trims the spaces This now is ready to go |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add flowtable object based on https://www.netfilter.org/projects/nftables/manpage.html