Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParseDump with an "empty" table declaration #15

Merged

Conversation

danwinship
Copy link
Collaborator

You can have an add table with no {} clause, but ParseDump didn't handle that.

(I also removed the use of noSpaceGroup here just to make the regexp more self-documenting.)

@danwinship danwinship requested a review from npinaeva August 26, 2024 14:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from aojea August 26, 2024 14:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2024
@npinaeva
Copy link
Member

/lgtm
Not sure though how removing the noSpaceGroup makes the regexp more self-documenting.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit 19fb4da into kubernetes-sigs:master Aug 26, 2024
5 checks passed
@danwinship danwinship deleted the parsedump-empty-table branch August 27, 2024 13:09
@danwinship
Copy link
Collaborator Author

Not sure though how removing the noSpaceGroup makes the regexp more self-documenting.

It makes it more obvious that there's a () there, to make it more obvious what the match indexes below refer to

@npinaeva
Copy link
Member

It makes it more obvious that there's a () there, to make it more obvious what the match indexes below refer to

I tried to express this with Group in the variable name, but in this small rule it's fine either way.

@danwinship
Copy link
Collaborator Author

yeah, I figured out that naming convention after chasing down the variable definition 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants