Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake: save and expose last transaction executed with Run(). #14

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

npinaeva
Copy link
Member

Allows to check the amount of operations in the last transaction with nft.LastTx.NumOperations()

@k8s-ci-robot k8s-ci-robot requested review from aojea and danwinship July 18, 2024 07:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2024
@danwinship
Copy link
Collaborator

Allows to check the amount of operations in the last transaction with nft.LastTx.NumOperations()

well, more than that; it lets you look at nft.LastTx.String()...

fake.go Outdated
@@ -34,6 +34,8 @@ type Fake struct {
// Table contains the Interface's table. This will be `nil` until you `tx.Add()`
// the table.
Table *FakeTable

LastTx *Transaction
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// LastTx is the last transaction passed to Run(). It will remain set until the
// next time Run() is called. (It is not affected by Check().)

Hm... and maybe LastTransaction though? None of the other (exported) field names are abbreviated...

Signed-off-by: Nadia Pinaeva <n.m.pinaeva@gmail.com>
@danwinship
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0a87068 into kubernetes-sigs:master Jul 21, 2024
5 checks passed
@npinaeva npinaeva deleted the fake-last-tx branch July 22, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants