Update Fake to support listing all rules #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
5 tasks
caseydavenport
force-pushed
the
casey-update-fake
branch
from
3f3f796 to
346d43a
Compare
k8s-ci-robot
added
size/M
|
@danwinship could you take a quick peek at this one when you have a moment? |
caseydavenport
commented
Jun 26, 2024
k8s-ci-robot
added
size/S
caseydavenport
force-pushed
the
casey-update-fake
branch
from
939adc9 to
346d43a
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caseydavenport, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hjiawei
added a commit
to hjiawei/calico
that referenced
this pull request
Nov 23, 2024
Update sigs.k8s.io/knftables to the latest release that includes the changes we need from [1] so we don't need to replace. [1] kubernetes-sigs/knftables#12
3 tasks
caseydavenport
pushed a commit
to projectcalico/calico
that referenced
this pull request
Nov 25, 2024
Update sigs.k8s.io/knftables to the latest release that includes the changes we need from [1] so we don't need to replace. [1] kubernetes-sigs/knftables#12
sridhartigera
pushed a commit
to sridhartigera/calico
that referenced
this pull request
Dec 18, 2024
Update sigs.k8s.io/knftables to the latest release that includes the changes we need from [1] so we don't need to replace. [1] kubernetes-sigs/knftables#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that I forgot to add support to the Fake client for my last PR: #7