-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NumOperations() method to Transaction. #11
Conversation
Useful for checking if the transation is empty before trying to execute it, for example.
Welcome @fasaxc! |
Yeah, I can definitely see the use case for that, but did you have any use case for knowing the exact number of operations? Would this be better as |
Might be nice to put in our prometheus metrics "felix_nft_txn_size", for example. |
ok |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, fasaxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the LGTM :-) |
Useful for checking if the transaction is empty before trying to execute it, for example.