-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: improve shell scripts #3843
base: main
Are you sure you want to change the base?
Refactor: improve shell scripts #3843
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: namejsjeongkr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @namejsjeongkr! |
Hi @namejsjeongkr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
649de8c
to
ce1710d
Compare
These changes aim to make the scripts more robust, easier to maintain, and more efficient while ensuring they follow the project's established coding patterns. (Please refer to the below key changes.)
e2e-k8s.sh
Enhanced error handling by adding set -o pipefail.
Improved code structure by extracting repeated tasks into functions.
Added informative log messages for better execution tracking.
Standardized variable usage to ${VARIABLE} format for consistency.
Retained temporary directory creation and cleanup logic for better resource management.
push-latest-cli.sh
Updated error handling to use set -o errexit -o nounset -o pipefail.
Introduced an upload_file function to reduce code duplication.
Implemented use of gsutil -m cp for parallel uploads to improve performance.
Added log messages at key steps for clearer execution tracking.
Standardized variable declarations using double quotes.