-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ingress from v1beta1 to v1 #2306
Conversation
Update ingress from v1bet1 to v1 and update `Ingress.spec.rules[0].http.paths[0].backend` changes. https://kubernetes.io/docs/concepts/services-networking/ingress/
Hi @juniorjbn. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
we discussed this some time ago, the problem is that this we are always going to break someone |
with 1.22 coming it might be time to switch though, we can add a note about this to the docs. |
kind: Ingress | ||
metadata: | ||
name: example-ingress | ||
spec: | ||
rules: | ||
- http: | ||
paths: | ||
- path: /foo | ||
- pathType: Prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we enter here on the compatiblity problem, some ingresses need
ImplementationSpecific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say which is better though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have to support all ingresses here, I'd prefer to use ingresses that can use portable upstream specs for the purposes of kind anyhow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say which pathType is more portabl XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefix is more portable :)
With Fixed you have all the traffic directed to a specific path only catched :)
this is going to be a drama XD, it took me a week to update k/k to v1, |
cc @rikatz |
at least nginx ingress is not going to work kubernetes/ingress-nginx#7145 |
Wanna release a beta next week :) |
Ingress Impl can't support both for some time? |
/hold |
related kubernetes/ingress-nginx#7305 , right now the examples doesn't work for nginx |
I think we should probably roll forward with this, people are confused about the ingress-nginx failures and kind is nominally shipping v1.21, with 1.19+ having v1 AIUI. Yes some users are still on <= v1.18, but, similarly we cannot patch bugs in Kubernetes for those versions anymore, the last patch release is done upstream since we first started talking about this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, juniorjbn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
bypassing github actions flakes. |
Update ingress from v1bet1 to v1 and update
Ingress.spec.rules[0].http.paths[0].backend
changes.https://kubernetes.io/docs/concepts/services-networking/ingress/