Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress from v1beta1 to v1 #2306

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

juniorjbn
Copy link
Contributor

Update ingress from v1bet1 to v1 and update Ingress.spec.rules[0].http.paths[0].backend changes.
https://kubernetes.io/docs/concepts/services-networking/ingress/

Update ingress from v1bet1 to v1 and update `Ingress.spec.rules[0].http.paths[0].backend` changes.
https://kubernetes.io/docs/concepts/services-networking/ingress/
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @juniorjbn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2021
@aojea
Copy link
Contributor

aojea commented Jun 13, 2021

we discussed this some time ago, the problem is that this we are always going to break someone
ingress/v1 is 1.19 IIRC, it won't work for previous versions
ingress/v1beta1 will stop to work since 1.22 🤷

@BenTheElder
Copy link
Member

ingress/v1 is 1.19 IIRC, it won't work for previous versions
ingress/v1beta1 will stop to work since 1.22 🤷

with 1.22 coming it might be time to switch though, we can add a note about this to the docs.
older releases have to eventually be best effort I think.

kind: Ingress
metadata:
name: example-ingress
spec:
rules:
- http:
paths:
- path: /foo
- pathType: Prefix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we enter here on the compatiblity problem, some ingresses need
ImplementationSpecific

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say which is better though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have to support all ingresses here, I'd prefer to use ingresses that can use portable upstream specs for the purposes of kind anyhow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say which pathType is more portabl XD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix is more portable :)

With Fixed you have all the traffic directed to a specific path only catched :)

@aojea
Copy link
Contributor

aojea commented Jun 17, 2021

with 1.22 coming it might be time to switch though, we can add a note about this to the docs.
older releases have to eventually be best effort I think.

this is going to be a drama XD, it took me a week to update k/k to v1,
but this is clear the way
/ok-to-test
@juniorjbn we don't have CI , have you tried it with at least one of the ingresses of the docs?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2021
@aojea
Copy link
Contributor

aojea commented Jun 17, 2021

cc @rikatz

@aojea
Copy link
Contributor

aojea commented Jun 17, 2021

at least nginx ingress is not going to work kubernetes/ingress-nginx#7145

@rikatz
Copy link
Contributor

rikatz commented Jun 17, 2021

Wanna release a beta next week :)

@BenTheElder
Copy link
Member

Ingress Impl can't support both for some time?

@aojea
Copy link
Contributor

aojea commented Jun 17, 2021

/hold
until we have some positive feedback that the examples work

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2021
@BenTheElder BenTheElder changed the title Update ingress from v1bet1 to v1 Update ingress from v1beta1 to v1 Jun 24, 2021
@aojea
Copy link
Contributor

aojea commented Jun 30, 2021

related kubernetes/ingress-nginx#7305 , right now the examples doesn't work for nginx

@BenTheElder
Copy link
Member

I think we should probably roll forward with this, people are confused about the ingress-nginx failures and kind is nominally shipping v1.21, with 1.19+ having v1 AIUI. Yes some users are still on <= v1.18, but, similarly we cannot patch bugs in Kubernetes for those versions anymore, the last patch release is done upstream since we first started talking about this issue.

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, juniorjbn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@aojea
Copy link
Contributor

aojea commented Jul 1, 2021

/hold cancel

@BenTheElder
Copy link
Member

bypassing github actions flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants