Skip to content

Release 2.1.1 #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
a6b43c4
Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.17.3
dependabot[bot] May 21, 2024
8e8a1ce
Do not start the PreflightValidation controller in managed mode
qbarrand May 21, 2024
e91dce2
Bump sigs.k8s.io/controller-runtime from 0.18.0 to 0.18.2
dependabot[bot] May 7, 2024
1ab1b4d
Bump github.com/docker/docker
dependabot[bot] May 17, 2024
e266fc4
Bump github.com/moby/moby
dependabot[bot] May 22, 2024
7e9a872
Bump github.com/prometheus/client_golang from 1.19.0 to 1.19.1
dependabot[bot] May 23, 2024
cf70279
Bump alpine from 3.19 to 3.20
dependabot[bot] May 23, 2024
d86117d
Bump github.com/onsi/ginkgo/v2 from 2.17.3 to 2.19.0
dependabot[bot] May 27, 2024
296a0ea
Bump github.com/go-logr/logr from 1.4.1 to 1.4.2
dependabot[bot] May 27, 2024
7cfc242
Bump Kubernetes dependencies
qbarrand Jun 2, 2024
9c809d6
Normalize kernel version in labels and image tags
qbarrand Jun 3, 2024
dce3bba
Do not start BuildSignReconciler in managed mode
qbarrand Jun 4, 2024
a2d94fe
Bump golang.org/x/text from 0.15.0 to 0.16.0
dependabot[bot] Jun 5, 2024
4f71816
Bump sigs.k8s.io/controller-runtime from 0.18.3 to 0.18.4
dependabot[bot] Jun 6, 2024
432989d
Bump github.com/docker/docker
dependabot[bot] Jun 13, 2024
2628233
Bump github.com/moby/moby
dependabot[bot] Jun 13, 2024
da8b486
Bump k8s.io/kubectl from 0.30.1 to 0.30.2
dependabot[bot] Jun 13, 2024
04fc397
Bump k8s.io/klog/v2 from 2.120.1 to 2.130.0
dependabot[bot] Jun 17, 2024
be35a55
Bump github.com/spf13/cobra from 1.8.0 to 1.8.1
dependabot[bot] Jun 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile.signimage
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
FROM alpine:3.19 as ksource
FROM alpine:3.20 as ksource

RUN ["apk", "add", "linux-virt-dev"]

FROM alpine:3.19
FROM alpine:3.20

COPY --from=ksource /usr/src/linux-headers-*-virt/scripts/sign-file /usr/local/bin/sign-file

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.worker
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ COPY .git .git
# Build
RUN ["make", "worker"]

FROM alpine:3.19
FROM alpine:3.20

RUN ["apk", "add", "ca-certificates", "kmod"]

Expand Down
91 changes: 46 additions & 45 deletions cmd/manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,8 @@ import (
"os"
"strconv"

"github.com/kubernetes-sigs/kernel-module-management/api/v1beta2"
"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
"k8s.io/klog/v2/textlogger"
clusterv1alpha1 "open-cluster-management.io/api/cluster/v1alpha1"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/healthz"

// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
// to ensure that exec-entrypoint and run can make use of them.
_ "k8s.io/client-go/plugin/pkg/client/auth"

"github.com/kubernetes-sigs/kernel-module-management/api/v1beta1"
"github.com/kubernetes-sigs/kernel-module-management/api/v1beta2"
"github.com/kubernetes-sigs/kernel-module-management/internal/build"
"github.com/kubernetes-sigs/kernel-module-management/internal/build/pod"
"github.com/kubernetes-sigs/kernel-module-management/internal/cmd"
Expand All @@ -51,6 +39,18 @@ import (
"github.com/kubernetes-sigs/kernel-module-management/internal/sign"
signpod "github.com/kubernetes-sigs/kernel-module-management/internal/sign/pod"
"github.com/kubernetes-sigs/kernel-module-management/internal/utils"

"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
"k8s.io/klog/v2/textlogger"
clusterv1alpha1 "open-cluster-management.io/api/cluster/v1alpha1"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/healthz"

// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
// to ensure that exec-entrypoint and run can make use of them.
_ "k8s.io/client-go/plugin/pkg/client/auth"
//+kubebuilder:scaffold:imports
)

Expand Down Expand Up @@ -117,23 +117,8 @@ func main() {
metricsAPI.Register()

registryAPI := registry.NewRegistry()
podHelperAPI := utils.NewPodHelper(client)
buildHelperAPI := build.NewHelper()

buildAPI := pod.NewBuildManager(
client,
pod.NewMaker(client, buildHelperAPI, podHelperAPI, scheme),
podHelperAPI,
registryAPI,
)

signAPI := signpod.NewSignPodManager(
client,
signpod.NewSigner(client, scheme, podHelperAPI),
podHelperAPI,
registryAPI,
)

kernelAPI := module.NewKernelMapper(buildHelperAPI, sign.NewSignerHelper())

dpc := controllers.NewDevicePluginReconciler(
Expand All @@ -145,16 +130,6 @@ func main() {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.DevicePluginReconcilerName)
}

bsc := controllers.NewBuildSignReconciler(
client,
buildAPI,
signAPI,
kernelAPI,
filterAPI)
if err = bsc.SetupWithManager(mgr, constants.KernelLabel); err != nil {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.BuildSignReconcilerName)
}

mnc := controllers.NewModuleNMCReconciler(
client,
kernelAPI,
Expand Down Expand Up @@ -183,13 +158,6 @@ func main() {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.NodeLabelModuleVersionReconcilerName)
}

preflightStatusUpdaterAPI := preflight.NewStatusUpdater(client)
preflightAPI := preflight.NewPreflightAPI(client, buildAPI, signAPI, registryAPI, preflightStatusUpdaterAPI, kernelAPI)

if err = controllers.NewPreflightValidationReconciler(client, filterAPI, metricsAPI, preflightStatusUpdaterAPI, preflightAPI).SetupWithManager(mgr); err != nil {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.PreflightValidationReconcilerName)
}

if managed {
setupLogger.Info("Starting as managed")

Expand All @@ -201,6 +169,32 @@ func main() {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.NodeKernelClusterClaimReconcilerName)
}
} else {
podHelperAPI := utils.NewPodHelper(client)

buildAPI := pod.NewBuildManager(
client,
pod.NewMaker(client, buildHelperAPI, podHelperAPI, scheme),
podHelperAPI,
registryAPI,
)

signAPI := signpod.NewSignPodManager(
client,
signpod.NewSigner(client, scheme, podHelperAPI),
podHelperAPI,
registryAPI,
)

bsc := controllers.NewBuildSignReconciler(
client,
buildAPI,
signAPI,
kernelAPI,
filterAPI)
if err = bsc.SetupWithManager(mgr, constants.KernelLabel); err != nil {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.BuildSignReconcilerName)
}

helper := controllers.NewJobEventReconcilerHelper(client)

if err = controllers.NewBuildSignEventsReconciler(client, helper, eventRecorder).SetupWithManager(mgr); err != nil {
Expand All @@ -210,6 +204,13 @@ func main() {
if err = controllers.NewJobGCReconciler(client, cfg.Job.GCDelay).SetupWithManager(mgr); err != nil {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.JobGCReconcilerName)
}

preflightStatusUpdaterAPI := preflight.NewStatusUpdater(client)
preflightAPI := preflight.NewPreflightAPI(client, buildAPI, signAPI, registryAPI, preflightStatusUpdaterAPI, kernelAPI)

if err = controllers.NewPreflightValidationReconciler(client, filterAPI, metricsAPI, preflightStatusUpdaterAPI, preflightAPI).SetupWithManager(mgr); err != nil {
cmd.FatalError(setupLogger, err, "unable to create controller", "name", controllers.PreflightValidationReconcilerName)
}
}

//+kubebuilder:scaffold:builder
Expand Down
Loading