-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable Netlify builds for the documents part of the repo #155
Conversation
Welcome @iranzo! |
Hi @iranzo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you please update the commit message (in addition to the PR description)? And BTW, thank you for that PR :) |
Done! |
/ok-to-test |
/retest |
Netlify is a service to build the documents in the repository into a web page for easier browsing. Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
Just rebased on top of main to let it force again, TY for the label! |
@iranzo could you add as few lines somewhere explaining how to build the website and maybe run it on a local server? Once that's done I would merge the PR. |
The netlify build is just running the makefile that is already present in the repo, that is Do you want me to add it to the commit message? I didn't as this was already enabled in the repository |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iranzo, qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportBase: 73.33% // Head: 73.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
==========================================
- Coverage 73.33% 73.09% -0.24%
==========================================
Files 25 26 +1
Lines 2438 2513 +75
==========================================
+ Hits 1788 1837 +49
- Misses 564 589 +25
- Partials 86 87 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Enables Netlify configuration for building the docs with actual Makefile 'make docs'
Closes #27