Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable Netlify builds for the documents part of the repo #155

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

iranzo
Copy link
Contributor

@iranzo iranzo commented Nov 16, 2022

Enables Netlify configuration for building the docs with actual Makefile 'make docs'

Closes #27

@k8s-ci-robot
Copy link
Contributor

Welcome @iranzo!

It looks like this is your first PR to kubernetes-sigs/kernel-module-management 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kernel-module-management has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @iranzo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2022
@ybettan
Copy link
Contributor

ybettan commented Nov 17, 2022

Can you please update the commit message (in addition to the PR description)?
Please see https://github.com/kubernetes-sigs/kernel-module-management/blob/main/CONTRIBUTING.md#commit-messages.

And BTW, thank you for that PR :)

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@iranzo
Copy link
Contributor Author

iranzo commented Nov 21, 2022

Can you please update the commit message (in addition to the PR description)? Please see main/CONTRIBUTING.md#commit-messages.

And BTW, thank you for that PR :)

Done!

@ybettan
Copy link
Contributor

ybettan commented Nov 22, 2022

/ok-to-test
/lgtm
/assign @qbarrand

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2022
@iranzo iranzo requested review from qbarrand and removed request for ybettan and yevgeny-shnaidman November 25, 2022 11:11
@ybettan
Copy link
Contributor

ybettan commented Dec 1, 2022

/retest
If it is not working, you will need to repush a new commit (you can just amend an empty commit message to the current one to update the commit sha)

Netlify is a service to build the documents in the repository into a web page
for easier browsing.

Signed-off-by: Pablo Iranzo Gómez <Pablo.Iranzo@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@iranzo
Copy link
Contributor Author

iranzo commented Dec 1, 2022

/retest If it is not working, you will need to repush a new commit (you can just amend an empty commit message to the current one to update the commit sha)

Just rebased on top of main to let it force again, TY for the label!

@qbarrand
Copy link
Contributor

qbarrand commented Dec 1, 2022

@iranzo could you add as few lines somewhere explaining how to build the website and maybe run it on a local server? Once that's done I would merge the PR.

@iranzo
Copy link
Contributor Author

iranzo commented Dec 1, 2022

@iranzo could you add as few lines somewhere explaining how to build the website and maybe run it on a local server? Once that's done I would merge the PR.

The netlify build is just running the makefile that is already present in the repo, that is make docs.

Do you want me to add it to the commit message? I didn't as this was already enabled in the repository

@ybettan
Copy link
Contributor

ybettan commented Dec 1, 2022

/lgtm
@qbarrand will approve when he is happy.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@qbarrand
Copy link
Contributor

qbarrand commented Dec 1, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iranzo, qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 73.33% // Head: 73.09% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (d625d31) compared to base (3cfe04b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   73.33%   73.09%   -0.24%     
==========================================
  Files          25       26       +1     
  Lines        2438     2513      +75     
==========================================
+ Hits         1788     1837      +49     
- Misses        564      589      +25     
- Partials       86       87       +1     
Impacted Files Coverage Δ
controllers/node_kernel_clusterclaim.go 58.73% <0.00%> (ø)
internal/filter/filter.go 85.09% <0.00%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k8s-ci-robot k8s-ci-robot merged commit afc3b6c into kubernetes-sigs:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a subproject site for docs
5 participants