Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add back approvers with kubernetes-sigs membership #820

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #N/A

Description

The following contributors were originally part of the original approvers list but did not have membership in kubernetes-sigs. These contributors now have membership and can be added back to the OWNERS_ALIASES file:

  1. @engedaam - REQUEST: New membership for engedaam kubernetes/org#4595
  2. @jmdeal - REQUEST: New membership for jmdeal kubernetes/org#4593

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Nov 24, 2023
@jonathan-innis
Copy link
Member Author

/verify-owners

@coveralls
Copy link

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 6991225346

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 79.629%

Totals Coverage Status
Change from base Build 6987766157: 0.07%
Covered Lines: 8123
Relevant Lines: 10201

💛 - Coveralls

@jonathan-innis
Copy link
Member Author

/verify-owners

1 similar comment
@jonathan-innis
Copy link
Member Author

/verify-owners

@jonathan-innis
Copy link
Member Author

/verify-owners

1 similar comment
@jonathan-innis
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 28, 2023
@engedaam
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7d4bb97 into kubernetes-sigs:main Nov 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants