feat: add component config

[rainfd]

Fix: #55
The basic configuration follows kueue.

[k8s-ci-robot]

Welcome @rainfd!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rainfd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	5ee5da1
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66dfa87800a119000816de1b

[ahg-g]

/ok-to-test

[danielvegamyhre]

Thanks for working on this @rainfd, I will review this soon

[danielvegamyhre]

FYI I am OOO for the next week or so but can review when I get back.

[danielvegamyhre]

Looks good, I would prefer to include a larger change like this in 0.7 release, rather than as a last minute addition to 0.6, so unless there's any objections that's what we'll do

[danielvegamyhre]

/hold

[danielvegamyhre]

/lgtm

Will leave approval for @ahg-g.

[ahg-g]

Thanks a lot for this!

[ahg-g]

Why don't we get the defaults as defined in SetDefaults_Configuration and then override the couple of parameters that have corresponding cmd flags if set? This will unify all defaulting in one place.

[ahg-g]

config.Load handles the case where the configFile is not set, so we just need to invoke it instead of defining defaults again here.

[rainfd]

Modify as you said, now check each flag individually and set the value.

[ahg-g]

Thanks, looks good, we need to fix the tests though.

[rainfd]

/test pull-jobset-test-unit-main

[ahg-g]

/label tide/merge-method-squash
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, rainfd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

/hold cancel

I think this is ready to go now.