Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for feature gates #557

Merged
merged 4 commits into from
May 17, 2024
Merged

Add support for feature gates #557

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
207a814
feature: add feature gate
googs1025 May 4, 2024
9042608
add featureGates flag
googs1025 May 12, 2024
a1c173d
set example featuregate to comment
googs1025 May 12, 2024
5fb8981
delete todo and test file
googs1025 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add featureGates flag
  • Loading branch information
@googs1025
googs1025 committed May 12, 2024
commit 90426088e81a40485aeba911ab8d36307f9b886b
9 changes: 9 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package main

import (
"flag"
utilfeature "k8s.io/apiserver/pkg/util/feature"
"os"

// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
Expand Down Expand Up @@ -58,13 +59,16 @@ func main() {
var probeAddr string
var qps float64
var burst int
var featureGates string
flag.StringVar(&metricsAddr, "metrics-bind-address", ":8080", "The address the metric endpoint binds to.")
flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
flag.BoolVar(&enableLeaderElection, "leader-elect", false,
"Enable leader election for controller manager. "+
"Enabling this will ensure there is only one active controller manager.")
flag.Float64Var(&qps, "kube-api-qps", 500, "Maximum QPS to use while talking with Kubernetes API")
flag.IntVar(&burst, "kube-api-burst", 500, "Maximum burst for throttle while talking with Kubernetes API")
flag.StringVar(&featureGates, "feature-gates", "", "A set of key=value pairs that describe feature gates for alpha/experimental features.")

opts := zap.Options{
Development: true,
}
Expand All @@ -77,6 +81,11 @@ func main() {
kubeConfig.QPS = float32(qps)
kubeConfig.Burst = burst

if err := utilfeature.DefaultMutableFeatureGate.Set(featureGates); err != nil {
setupLog.Error(err, "Unable to set flag gates for known features")
os.Exit(1)
}

mgr, err := ctrl.NewManager(kubeConfig, ctrl.Options{
Scheme: scheme,
Metrics: server.Options{
Expand Down