Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set node affinity during unsuspend #142

Closed
wants to merge 3 commits into from
Closed

Set node affinity during unsuspend #142

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
897d1b0
implemented nodeAfinties on resume job
mcariatm May 12, 2023
36eb2f1
Updated integration jobs
mcariatm May 15, 2023
3774592
updated validation webhook for imutable replicatedJobs
mcariatm May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
implemented nodeAfinties on resume job
  • Loading branch information
@mcariatm
mcariatm committed May 12, 2023
commit 897d1b0155525bb4d0f7bf54aa8b2e3fa5549257
8 changes: 8 additions & 0 deletions pkg/controllers/jobset_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"errors"
"fmt"
"strconv"
"strings"
"sync"

batchv1 "k8s.io/api/batch/v1"
Expand Down Expand Up @@ -238,10 +239,17 @@ func (r *JobSetReconciler) suspendJobSet(ctx context.Context, js *jobset.JobSet,
}

func (r *JobSetReconciler) resumeJobSetIfNecessary(ctx context.Context, js *jobset.JobSet, ownedJobs *childJobs) error {
nodeAffinities := map[string]map[string]string{}
for _, replicatedJob := range js.Spec.ReplicatedJobs {
nodeAffinities[fmt.Sprintf("%s-%s", js.Name, replicatedJob.Name)] = replicatedJob.Template.Spec.Template.Spec.NodeSelector
}

// If JobSpec is unsuspended, ensure all active child Jobs are also
// unsuspended and update the suspend condition to true.
for _, job := range ownedJobs.active {
if pointer.BoolDeref(job.Spec.Suspend, false) != false {
i := strings.LastIndex(job.Name, "-")
job.Spec.Template.Spec.NodeSelector = nodeAffinities[job.Name[:i]]
job.Spec.Suspend = pointer.Bool(false)
if err := r.Update(ctx, job); err != nil {
return err
Expand Down