-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and *use* the ansible.cfg file #584
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codenrhoden The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm also fairly confident this doesn't affect Windows, since the issue is about TTY and |
Both CentOS and AL2 on Amazon failed with:
This is from the the |
Wow, this opened a can of worms on my end. Starting to piece together all effects that are happening, and i think this will turn into a meaningiful cleanup. But it was more impactful than I suspected. Stay tuned. |
The ansible.cfg file that is present in images/capi/ansible is not used in any way because the Ansible commands won't pick it up in that location. Since Ansible is run with a PWD of images/capi, put it there instead. Additionally, the .cfg file mistakenly had 'default' instead of 'defaults', meaning that all entries were being ignored. We no longer need to specify a search path for filter plugins since we haven't used any in a while, and the setting for retry files is already the default in Ansible.
bca004c
to
96f269d
Compare
After playing with this for a bit, I figured out that enabling SSH pipelining is likely to take more work. So, in the interest of time, this just places the /hold cancel |
Thanks for fixing this @codenrhoden . |
/test pull-azure-vhds |
What this PR does / why we need it:
The
ansible.cfg
file that is present inimages/capi/ansible
is not usedin any way because the Ansible commands won't pick it up in that
location. Since Ansible is run with a PWD of
images/cap
i, put it thereinstead.
Additionally, the .cfg file mistakenly had 'default' instead of
'defaults', meaning that all entries were being ignored. We no longer
need to specify a search path for filter plugins since we haven't used
any in a while, and the setting for retry files is already the default
in Ansible.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
This makes what is being sought in #531 a lot easier (I tested it, it works, but wanted to leave that PR separate).
/hold
With this change in place, SSH Pipeline will be used. This is a change that can significantly speed up builds. I've got the
/hold
in place because we at least need to make sure that every OS we currently build works with this change. If any OS hasrequiretty
set by default in/etc/sudoers
, it won't work. This is becoming less common, but I have no idea who sets it and who doesn't at this point./assign @kkeshavamurthy @detiber @CecileRobertMichon
if anyone does get a chance to take this for a spin, mind putting in a note what OS/provider combintation you tried to make sure the SSH pipelining worked?