Add vsphere-clone builder to decrease build time #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
EleanorRigby
force-pushed
the
ta-vsphereClone
branch
2 times, most recently
from
3362f5a
to
a02bcac
Compare
|
Can you review this? @kkeshavamurthy , @figo |
EleanorRigby
force-pushed
the
ta-vsphereClone
branch
2 times, most recently
from
aabae64
to
0ec234c
Compare
k8s-ci-robot
added
the
needs-rebase
- Add vsphere-iso-base named builder to build a base image from iso
using kickstart. The `builder` packer user is left intact on this image
for consumption by `vsphere-clone` builder in next step.
- images emitted by vsphere-iso-base are prefixed with `base-`.
- base image name changes made to `vmware-iso-base` vm and disk name too.
- introduces new vsphere related params
+ create_snapshot: create snapshot before converting to template.
Useful for linked cloning which is way faster than full clone.
+ linked_clone: enables link clone for `vsphere-clone` builder.
+ template: template used by `vsphere-clone` builder
EleanorRigby
force-pushed
the
ta-vsphereClone
branch
from
0ec234c
to
1d3263d
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Added docs. |
|
looks good to me. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EleanorRigby, figo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vsphere-iso-basebuilder to build a base image from iso using kickstart. Thebuilderpacker user is left intact on this image for consumption byvsphere-clonebuilder in the next step.base-.vmware-iso-baseVM and disk name too.Useful for linked cloning which is way faster than a full clone.
vsphere-clonebuilder.vsphere-clonebuilder