Allow multiple custom roles

[xtreme-nitin-ravindran]

This PR allows user to use multiple custom roles to be run before sysprep

[k8s-ci-robot]

Hi @xtreme-nitin-ravindran. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xtreme-nitin-ravindran]

/assign @akutz

[fejta-bot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

[codenrhoden]

Hi @xtreme-nitin-ravindran, this seems like a pretty reasonable change to me. I appreciate that you updated the docs along with it. :)

I don't think this needs to be split into 4 separate commits, please squash them into 1.

[xtreme-nitin-ravindran]

Hi @codenrhoden Done. Thank you.

[codenrhoden]

Just took this for a spin - it works as expected.

Note that since this is space delimited (just like other args like extra_rpms), if specifying more than one role, you need to escape the double quotes.

For example, if you have two custom roles named "custom1" and "custom2", and you put them in a JSON file, they'd need to be defined like this:

{
  "custom_role": "true",
  "custom_role_names": "\"custom1 custom2\""
}

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, xtreme-nitin-ravindran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [codenrhoden]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment