-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase Bandwidth for TCP to 1MB on Photon OS #319
Conversation
Hi @EleanorRigby. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
03f0c34
to
a9740d6
Compare
- Photon's default kernel value for `net.ipv4.tcp_limit_output_bytes` is 256K compared to 1MB in Ubuntu
a9740d6
to
73c16f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I have enough context here, is this something that we should also look to the Photon team to change in their defaults? |
I believe the Photon team is sticking what is default in the base kernel, which changes in kernel 5.0. But this handles the other cases. I'll ping someone who can chime in more. |
sysctl: | ||
name: net.ipv4.tcp_limit_output_bytes | ||
value: "1048576" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything we need to do to have the GOSS kernel param verification check this as well?
I know this would be a new/diff case because it's distro-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be added to PR #307 if this merges first. Else later to PhotonOS kernel param section in goss-vars.yml
Upstream recommendation for 4.19 kernel is 256kB, the default changed with code changes in 5.0 kernel version like @codenrhoden mentioned. The recommendation usually covers multiple use cases, but like in the change here it can always be tuned to conform to specific requirements. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codenrhoden, EleanorRigby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
net.ipv4.tcp_limit_output_bytes
to1048576
net.ipv4.tcp_limit_output_bytes
is 256K compared to 1MB in UbuntuGOSS Kernel param entry for this will be added in #307
Run result on powered on VM
/assign : @codenrhoden