Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Bandwidth for TCP to 1MB on Photon OS #319

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

EleanorRigby
Copy link
Contributor

@EleanorRigby EleanorRigby commented Aug 6, 2020

  • Set net.ipv4.tcp_limit_output_bytes to 1048576
  • Photon's default kernel value for net.ipv4.tcp_limit_output_bytes is 256K compared to 1MB in Ubuntu

GOSS Kernel param entry for this will be added in #307

Run result on powered on VM

root [ /home/capv ]# cat /etc/os-release
  NAME="VMware Photon OS" 
  VERSION="3.0"
  ID=photon 
  VERSION_ID=3.0
  PRETTY_NAME="VMware Photon OS/Linux"
  ANSI_COLOR="1;34"
  HOME_URL="https://vmware.github.io/photon/"
  BUG_REPORT_URL="https://github.com/vmware/photon/issues"
root [ /home/capv ]# sysctl -a | grep net.ipv4.tcp_limit_output_bytes
  net.ipv4.tcp_limit_output_bytes = 1000000000
root [ /home/capv ]#

/assign : @codenrhoden

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @EleanorRigby. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2020
@EleanorRigby EleanorRigby changed the title Increase Bandwidth for TCP to ~ 1GB on Photon OS Increase Bandwidth for TCP to 1MB on Photon OS Aug 6, 2020
  - Photon's default kernel value for
  `net.ipv4.tcp_limit_output_bytes` is 256K compared to 1MB in Ubuntu
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2020
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/assign @dims @detiber

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2020
@detiber
Copy link
Member

detiber commented Aug 7, 2020

Not sure if I have enough context here, is this something that we should also look to the Photon team to change in their defaults?
Travis might have some thoughts around this as well.
/assign @codenrhoden

@codenrhoden
Copy link
Contributor

I believe the Photon team is sticking what is default in the base kernel, which changes in kernel 5.0. But this handles the other cases. I'll ping someone who can chime in more.

sysctl:
name: net.ipv4.tcp_limit_output_bytes
value: "1048576"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we need to do to have the GOSS kernel param verification check this as well?

I know this would be a new/diff case because it's distro-specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be added to PR #307 if this merges first. Else later to PhotonOS kernel param section in goss-vars.yml

@suezzelur
Copy link

Not sure if I have enough context here, is this something that we should also look to the Photon team to change in their defaults?
Travis might have some thoughts around this as well.
/assign @codenrhoden

Upstream recommendation for 4.19 kernel is 256kB, the default changed with code changes in 5.0 kernel version like @codenrhoden mentioned. The recommendation usually covers multiple use cases, but like in the change here it can always be tuned to conform to specific requirements.

@dims dims removed their assignment Aug 10, 2020
@codenrhoden
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, EleanorRigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 87027ff into kubernetes-sigs:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants