Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Hyper-V KVP daemon for Ubuntu AMI #316

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

codenrhoden
Copy link
Contributor

So I stumbled across this today when building Ubuntu AMIs and taking a look at the console output (something I had not done before). I noticed that it was relatively slow (IMO, and compared to AL2) to be able to SSH in after the instance showed as running. Then I saw this on the console:

A start job is running for sys-devi…v_kvp.device (1min 29s / 1min 30s)^M
[  *** ] A start job is running for sys-devi…v_kvp.device (1min 29s / 1min 30s)^M
[ TIME ] Timed out waiting for device sys-de…rtual-misc-vmbus\x21hv_kvp.device.
[DEPEND] Dependency failed for Hyper-V KVP Protocol Daemon.

I've seen that before! The exact same thing was fixed for OVAs about six months ago: c06617b

Let's give everyone launching Ubuntu 18.04 AMIs ~90 seconds off their boot time.

/assign @detiber

Time to cloud-init is finished before:
[ 108.766451] cloud-init[1272]: Cloud-init v. 20.2-45-g5f7825e2-0ubuntu1~18.04.1 running 'modules:final' at Wed, 05 Aug 2020 01:16:43 +0000. Up 108.60 seconds.
After:
[ 23.096428] cloud-init[1129]: Cloud-init v. 20.2-45-g5f7825e2-0ubuntu1~18.04.1 running 'modules:final' at Wed, 05 Aug 2020 02:22:51 +0000. Up 22.94 seconds.

When launching Ubuntu 18.04 AMIs, it can be seen from the console
output that that a kernel daemon fails on startup, with the name
"Dependency failed for Hyper-V KVP Protocol Daemon." This adds over 90
seconds of boot time to the instance. Since AMIs are only running on
AWS, there is no need for a Hyper-V daemon, and it can safely be
disabled. The same steps were taken for OVAs/ESX images months ago.

When launching Ubuntu 18.04 AMIs, it can be seen from the console
output that that a kernel daemon fails on startup, with the name
"Dependency failed for Hyper-V KVP Protocol Daemon." This adds over 60
seconds of boot time to the instance. Since AMIs are only running on
AWS, there is no need for a Hyper-V daemon, and it can safely be
disabled. The same steps were taken for OVAs/ESX images months ago.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@dims
Copy link
Member

dims commented Aug 5, 2020

very cool!

@detiber
Copy link
Member

detiber commented Aug 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit eafe59d into kubernetes-sigs:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants