Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capi-ubuntu24): pin cloud-init deb package version #1586

Merged

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Oct 11, 2024

Change description

Newer version published on Ubuntu upstream stable channel introduced differences in cloud-init behavior making AMI builds stale. Several issues are around community/projects and there is not yet consensus on how to move forward. At the same time, project is stale because of this and a lot of users are affected.

Pinning cloud-init version to what we know for sure it's working to unblock development. This is tested for both amd64/arm64 arch.

Related issues

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2024
Newer version published on Ubuntu upstream stable channel introduced
differences in cloud-init behavior making AMI builds stale. Several
issues are around community/projects and there is not yet consensus on
how to move forward. At the same time, project is stale because of this
and a lot of users are affected.

Pinning cloud-init version to what we know for sure it's working to
unblock development. This is tested for both amd64/arm64 arch.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the feat/capi-ubuntu24-cloud-init-fix branch from 47e27e4 to d36d44a Compare October 11, 2024 05:40
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @mboersma

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit d7a820b into kubernetes-sigs:main Oct 11, 2024
8 checks passed
@dntosas dntosas deleted the feat/capi-ubuntu24-cloud-init-fix branch October 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants