-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin packer version to 1.9.5 #1383
pin packer version to 1.9.5 #1383
Conversation
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I'm seeing this in the logs: hack/ensure-packer.sh
Packer is already installed, checking version...
make: *** [Makefile:61: deps-common] Error 141 |
Hey. sorry for being late here and because of that the patch was open for a while now. :( - existing_packer_version=$(packer version | head -1 | cut -d 'v' -f 2)
+ existing_packer_version=$(packer version | head -1 | cut -d 'v' -f 2; exit 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@kranurag7 could you squash the commits into one and force-push?
e66f4bf
to
042ee68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @AverageMarcus @drew-viles |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: drew-viles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Actually @kranurag7 can you resquash the commits again please? |
if packer version is greater than 1.9.5 in semver terms then downgrade packer. Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
b37d352
to
0eb9896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'll leave it to @drew-viles to unhold :)
/unhold |
Sorted. Thanks for this and your patience with us! @kranurag7 |
if packer version is greater than 1.9.5 in semver terms then downgrade packer.
Fixes #1379
with centos container
docker run --rm -it centos:latest sh # put hack/utils.sh & hack/ensure-packer.sh and +x permissions. sh-4.4# ./packer.sh Packer is already installed, checking version... unexpected packer found
with 1.10.0 version of packer
$ ./hack/ensure-packer.sh Packer is already installed, checking version... unsupported packer version (1.10.0) found current packer version: 1.10.0 is not supported Downgrading packer to 1.9.5 Installing packer v1.9.5 in .local/bin packer_1.9.5_linux_amd64.zip: OK Archive: packer_1.9.5_linux_amd64.zip inflating: packer
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Add any other context for the reviewers