Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include main in branches for Azure nightly job #1176

Merged

Conversation

AverageMarcus
Copy link
Member

What this PR does / why we need it:

Includes the main branch in the triggers for the Azure nightly build job in preparation of renaming the master branch.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Towards: #1161

Additional context
Add any other context for the reviewers

Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@jsturtevant
Copy link
Contributor

/lgtm
/hold for @mboersma, we might require some changes on our internal pipelines

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

I don't think we have any other triggered pipelines, although we will definitely have to play some catch-up once the branch is actually renamed.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@AverageMarcus
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@AverageMarcus: The following commands are available to trigger required jobs:

  • /test json-sort-check
  • /test pull-azure-vhds
  • /test pull-goss-populate
  • /test pull-ova-all
  • /test pull-packer-validate

The following commands are available to trigger optional jobs:

  • /test pull-azure-sigs
  • /test pull-container-image-build
  • /test pull-image-builder-gcp-all

Use /test all to run the following jobs that were automatically triggered:

  • pull-azure-sigs
  • pull-azure-vhds
  • pull-packer-validate

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AverageMarcus
Copy link
Member Author

/test pull-azure-vhds

@k8s-ci-robot k8s-ci-robot merged commit 4d4774b into kubernetes-sigs:master Jun 5, 2023
@AverageMarcus AverageMarcus deleted the azure_nightly_branch branch June 6, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants