Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unmaintained projects #1175

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

AverageMarcus
Copy link
Member

What this PR does / why we need it:

Removes the following from the repo:

  • konfigadm
  • kube-deploy
  • Abandoned image-builder CLI

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #1143

Additional context
I removed each project in its own commit so it should be easy to revert a single project if we ever need to bring them back.

Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@AverageMarcus
Copy link
Member Author

/assign @mboersma @kkeshavamurthy @jsturtevant

Copy link
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!
Separating them out into their own commits seems like a logical idea for a back out process if it's required.
I only have the one doc comment from my side.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! couple minor suggestions

README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Co-authored-by: James Sturtevant <jsturtevant@gmail.com>
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7e6fb42 into kubernetes-sigs:master Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@AverageMarcus AverageMarcus deleted the repo_cleanup branch June 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unmaintained projects from image-builder
6 participants