Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mounting of bpffs in OS images #384

Closed
northrup opened this issue Sep 22, 2020 · 9 comments
Closed

Adding mounting of bpffs in OS images #384

northrup opened this issue Sep 22, 2020 · 9 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@northrup
Copy link

As more CNI projects are moving to support BPF (eBPF) there is a genuine need to have this mounted as a prerequisite to the CNI provider starting to eliminate traffic restarts due to mounting / unmountng of the bpffs by the CNI. I would like to propose that we craft the images with the bpffs set to mount at startup. For those not using a CNI that takes advantage of BPF it shouldn't be a problem, for those that do it means that they don't have to roll their own custom images for using CAPI just to have stable BPF support

@kkeshavamurthy
Copy link
Member

I have not checked on all OSses but on photon-3 and Ubuntu-20.04 bpf is mounted by default.

builder@localhost [ ~ ]$ sudo mount |grep bpf
bpf on /sys/fs/bpf type bpf (rw,nosuid,nodev,noexec,relatime,mode=700)
builder@localhost [ ~ ]$ cat /etc/issue
Welcome to Photon 3.0 (\m) - Kernel \r (\l)
builder@localhost [ ~ ]$

➜  ~ sudo mount |grep bpf
none on /sys/fs/bpf type bpf (rw,nosuid,nodev,noexec,relatime,mode=700)
➜  ~ cat /etc/issue
Ubuntu 20.04.1 LTS \n \l

@northrup
Copy link
Author

@kkeshavamurthy, thanks for checking on Photon-3 and Ubuntu 20.04!
Do you have any objects on back porting this to earlier versions (i.e. Ubuntu 18.04) and other base images?

@kkeshavamurthy
Copy link
Member

no problem. I checked on Ubuntu 18.04 and it's not mounted by default.
I do not have any objections.

@moshloop
Copy link
Contributor

I am not sure that the kernels included in earlier versions have enough eBPF support to fully support these CNI's, e.g. Cilium requires 4.19.57 to support all functionality while Ubuntu 18.04 only has 4.15, Calico seems to only support 20.04+

@northrup
Copy link
Author

🤔 thats a good point @moshloop

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 26, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants