Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all maintainers to k8s.io OWNERS #1156

Closed
mboersma opened this issue May 11, 2023 · 8 comments
Closed

Add all maintainers to k8s.io OWNERS #1156

mboersma opened this issue May 11, 2023 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mboersma
Copy link
Contributor

mboersma commented May 11, 2023

In trying to sync up housekeeping files with current image-builder owners (see kubernetes/k8s.io#5263), I wasn't able to add @EleanorRigby or @kkeshavamurthy because they're not yet members of the kubernetes GitHub org.

Membership in kubernetes-sigs is transferable to kubernetes, so this should be just a matter of requesting membership. When that is granted, we can create PRs to grant appropriate owner access.

/kind feature
/assign @kkeshavamurthy @EleanorRigby

@mboersma
Copy link
Contributor Author

mboersma commented Jun 2, 2023

/unassign @EleanorRigby
see #1173.

@mboersma
Copy link
Contributor Author

mboersma commented Jun 2, 2023

@kkeshavamurthy I see that if you try to join the kubernetes org, it says:

Please note, if you are already part of any Kubernetes GitHub organization like kubernetes-sigs and you are filing this request to be added to kubernetes, you do not need to open this request and can add yourself directly! The org memberships are now equivalent and sponsorship is not needed to join additional Kubernetes GitHub orgs.

So you should be able to make a pull request directly against kubernetes/org as described here by adding yourself to /config/kubernetes/org.yaml.

@kkeshavamurthy
Copy link
Member

Thanks @mboersma
I've opened the PR

@mboersma
Copy link
Contributor Author

mboersma commented Jun 6, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma reopened this Jun 6, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Jun 6, 2023

I closed this prematurely: see kubernetes/k8s.io#5369

@mboersma
Copy link
Contributor Author

mboersma commented Jun 6, 2023

/close

This time for reals.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closing this issue.

In response to this:

/close

This time for reals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants