Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #263

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Code refactoring #263

merged 3 commits into from
Oct 6, 2022

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Oct 4, 2022 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Remove the need for IBM-Cloud/bluemix-go package
  • Handling parsing providerid in one place via TokenizeProviderID function
  • Using only zone while creating powervs client
  • Deriving the account id from the resource itself(not from the token)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 4, 2022
@mkumatag mkumatag added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 4, 2022
Madhan-SWE
Madhan-SWE reviewed Oct 4, 2022
View reviewed changes
pkg/cloud/powervs.go Outdated Show resolved Hide resolved
Madhan-SWE
Madhan-SWE reviewed Oct 4, 2022
View reviewed changes
pkg/cloud/powervs.go Outdated Show resolved Hide resolved
Madhan-SWE
Madhan-SWE reviewed Oct 4, 2022
View reviewed changes
pkg/cloud/metadata.go Outdated Show resolved Hide resolved
@Madhan-SWE
Copy link

/retest

@mkumatag
Copy link
Member Author

mkumatag commented Oct 4, 2022

Finally CI is happy and @Madhan-SWE addressed all your comment, ptal latest commits.

@Madhan-SWE
Copy link

Madhan-SWE commented Oct 6, 2022 •
edited
Loading

looks good to me.Can we fix up the commit messages with the first commit message?
(as the 2nd and 3rd commits are just fix commits)

@mkumatag
Copy link
Member Author

mkumatag commented Oct 6, 2022

looks good to me.Can we fix up the commit messages with the first commit message?
(as the 2nd and 3rd commits are just fix commits)

This will be taken care automatically when bot squashes and merges the PR

@Madhan-SWE
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit d3d499c into kubernetes-sigs:main Oct 6, 2022
Madhan-SWE pushed a commit to Madhan-SWE/ibm-powervs-block-csi-driver-upstream that referenced this pull request Oct 31, 2022
@mkumatag @rcmadhankumar
Code refactoring (kubernetes-sigs#263)
97d9982 
* Code refactoring

* fix tests

* fix review comments and verify script error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhan-SWE Madhan-SWE Madhan-SWE left review comments

Assignees

@Madhan-SWE Madhan-SWE

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkumatag @k8s-ci-robot @Madhan-SWE