Migrate kube-webhook-certgen to k8s.gcr.io/ingress-nginx:v1.1.1 #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30. The jet upstream is no longer supported. It was forked, moved into kubernetes/ingress-nginx, fixed and is now published at k8s.gcr.io/ingress-nginx. See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
k8s-ci-robot
added
kind/bug
|
Thanks for catching this @michaelbeaumont! Just tested this fix out and it worked great for me. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelbeaumont, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The admission webhook certificate generation fails on k8s v1.22, see jet/kube-webhook-certgen#30.
The jet upstream is no longer supported.
It was forked, moved into kubernetes/ingress-nginx, fixed
and is now published at k8s.gcr.io/ingress-nginx.
See also https://github.com/kubernetes/k8s.io/blob/main/k8s.gcr.io/images/k8s-staging-ingress-nginx/images.yaml
Which issue(s) this PR fixes:
Fixes #990
Does this PR introduce a user-facing change?: