-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate validation from CRD & Webhook #872
Remove duplicate validation from CRD & Webhook #872
Conversation
Welcome @we4tech! |
Hi @we4tech. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this @we4tech! Mostly LGTM, just 1 tiny nit.
b698017
to
aceb299
Compare
Hi @robscott, I just addressed your comment. Appreciate your review. Let me know if you find anything else. |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, we4tech The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
listener.hostname
validation from the Webhooklistener.hostname
validation pattern to the CRDThis PR removes the duplicate validation rules and keeps one source.
Which issue(s) this PR fixes:
Fixes #868
Does this PR introduce a user-facing change?: