-
Notifications
You must be signed in to change notification settings - Fork 594
Fix broken link in TLS Configuration page #4091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @4n86rakam1! |
Hi @4n86rakam1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thanks @4n86rakam1! /lgtm |
@robscott it’d be great to get this merged soon, since the page is broken right now. |
Thanks for this fix! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 4n86rakam1, snorwin, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The TLS Configuration page returns a
Macro Rendering Error
because the location of the included yaml file has changed, so I changed it to the correct path.make live-docs
returns an expected page when I run it locally.Which issue(s) this PR fixes:
Fixes #4090
Does this PR introduce a user-facing change?: