-
Notifications
You must be signed in to change notification settings - Fork 598
Add body to http.Request and roundTripper.request to extend conformance testutil ability to send request with body. #3853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @zetxqx! |
Hi @zetxqx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zetxqx!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
The conformance testutil roundTripper and http.request does not allow to pass a request body into it.
This PR added the ability to set the request body which is needed in inference-gateway-extention conformance test PR#961
Which issue(s) this PR fixes:
Fixes # N/A
Does this PR introduce a user-facing change?: