Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GRPCRoute v1alpha2's status a subresource #3412

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Make GRPCRoute v1alpha2's status a subresource #3412

merged 1 commit into from
Oct 28, 2024

Conversation

kflynn
Copy link
Contributor

@kflynn kflynn commented Oct 25, 2024

/kind bug
/kind regression

Replace the kubebuilder flags for GRPCRoute v1alpha2 so that they're the same as v1. Also restore the additional printer columns.

Fixes #3411.

Make GRPCRoute v1alpha2's status a subresource again, as it should be, and restore the previous additional printer columns.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 25, 2024
mlavacca
mlavacca reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and fixing this, @kflynn!

CI is failing as we have done major changes in the prow jobs recently. I'm cherry picking the affecting PRs to 1.1 in #3417. You may need to rebase once the commits have been successfully backported.

@mlavacca
Copy link
Member

Let's try straight ahead

/retest

shaneutt
shaneutt reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
mlavacca
mlavacca reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mlavacca
Copy link
Member

@kflynn your commit message is invalid as it contains the issue reference.

@kflynn
Replace the kubebuilder flags for GRPCRoute v1alpha2 so that they're …
a66089d 
…the same as v1.

Signed-off-by: Flynn <emissary@flynn.kodachi.com>
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Oct 28, 2024
@kflynn
Copy link
Contributor Author

kflynn commented Oct 28, 2024

Rebased and removed the "Fixes #3411" from the commit message. I've never understood why that's a problem. 🤷‍♂️ 🙂

@shaneutt shaneutt added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 28, 2024
shaneutt
shaneutt approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 53ba0e3 into kubernetes-sigs:release-1.1 Oct 28, 2024
9 checks passed
@kflynn kflynn deleted the flynn/fix-subresource branch October 28, 2024 14:44
@mikemorris
Copy link
Contributor

For clarity, are there any implications for implementations here that are needed regarding this fix?

@mlavacca
Copy link
Member

For clarity, are there any implications for implementations here that are needed regarding this fix?

I think the only implication from the implementations' standpoint is that now v1alpha2 GRPCRoute status is settable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca left review comments

@shaneutt shaneutt shaneutt approved these changes

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kflynn @mlavacca @k8s-ci-robot @mikemorris @shaneutt