-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Transition to crd-ref-docs #3204
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gcs278 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update to use crd-ref-docs which is actively maintained and includes improvements over gen-crd-api-reference-docs.
Update: Unfortunately it's not a just-plug-it-in thing. I have a couple of things to figure out:
Side note: The type in current docs GRPCRouteFilter is displaying I'll need to get back to some of my regular scheduled programming, but I'm going leave this here for when I get some free time to fiddle with this implementation. I won't offended if someone finds this PR and wants to pick it up from here. |
Thanks for the work on this @gcs278! Unfortunate that it's not just a drop-in replacement, but hopefully it's possible to get past some of these limitations at some point. It's interesting to see the way Elastic uses this package with different pages for each API group. I'm not sure if that would help us out here, but it might make things a bit easier to understand. Ideally there would be an easy way to exclude types from pages and/or highlight only root objects. I think Envoy Gateway also uses this for their reference docs, maybe @arkodg or someone else working on that project would have some tips here? |
I like that formatting. It feels more organized to not have every API version on a single page (I use ctrl-f a lot and that can be confusing looking for a specific field). |
Note: elastic/crd-ref-docs#86 will be pretty important, as crd-ref-docs always returns exit code 0, even when it fails generation. I also opened elastic/crd-ref-docs#85 as the markdown template examples had incorrect format. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@gcs278: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Unfortunately I don't have the bandwidth to keep this going, and I'd like to focus on other Gateway API items, but I am willing to help support anyone that wants to pick this back up and work on it. |
@gcs278: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Update to use crd-ref-docs which is actively maintained and includes improvements over gen-crd-api-reference-docs.
Which issue(s) this PR fixes:
#3016
Does this PR introduce a user-facing change?:
WIP: Still ironing out the details to keep get the https://gateway-api.sigs.k8s.io/reference/spec page looking similar to what we have now.