Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests for in-cluster Gateway infrastructure #3192

Conversation

keithmattix
Copy link
Contributor

What type of PR is this?

/area conformance
/kind test

What this PR does / why we need it:
Adds conformance tests to move in-cluster Gateway deployments GEP to standard

Which issue(s) this PR fixes:

Part of #1762

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance kind/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2024
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix
Copy link
Contributor Author

/retest

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix
Copy link
Contributor Author

@arkodg can you let me know if Envoy Gateway can pass these conformance tests?

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Jul 23, 2024
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Copy link
Contributor

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 from ciliium team, Thanks for adding this test 👍

conformance/tests/gateway-infrastructure.go Outdated Show resolved Hide resolved
conformance/tests/gateway-infrastructure.go Show resolved Hide resolved
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
…ource

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Copy link
Contributor

@mikemorris mikemorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

conformance/tests/gateway-infrastructure.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
Copy link
Contributor

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@robscott
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: keithmattix, robscott, sayboras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@keithmattix
Copy link
Contributor Author

keithmattix commented Jul 26, 2024

Thanks everyone!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit e3bc718 into kubernetes-sigs:main Jul 26, 2024
8 checks passed
@keithmattix keithmattix deleted the in-cluster-gateway-infra-conformance branch July 26, 2024 15:56
xtineskim pushed a commit to xtineskim/gateway-api that referenced this pull request Aug 8, 2024
…es-sigs#3192)

* Add conformance tests for in-cluster Gateway infrastructure

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Fix lint and type errors

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* gofmt

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Check services as well

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Promote GEP to standard

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Add boilerplate

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Fix args

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Rewrite logic to check for metadata propagation for each matching resource

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

---------

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@arkodg
Copy link
Contributor

arkodg commented Aug 13, 2024

@arkodg can you let me know if Envoy Gateway can pass these conformance tests?

saw this a little too late 🙈 , to avoid being the bottle neck in the future I've raised #3266 so contributors can run conformance tests on envoy-gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants