-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add conformance report for KIC 3.2.0 #3152
chore: add conformance report for KIC 3.2.0 #3152
Conversation
|
Welcome @czeslavo! |
Hi @czeslavo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3ecf50b
to
6f47824
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @czeslavo!
/ok-to-test
|
||
| API channel | Implementation version | Mode | Report | | ||
|-------------|-------------------------------------------------------------------------------------|------|------------------------------| | ||
| x | [v3.2.0](https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v3.2.0) | x | [link](./v3.2.0-report.yaml) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rename the report according to the rules stated here: https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Done.
6f47824
to
11709d1
Compare
|
||
| API channel | Implementation version | Mode | Report | | ||
|--------------|-------------------------------------------------------------------------------------|-------------|------------------------------| | ||
| experimental | [v3.2.0](https://github.com/Kong/kubernetes-ingress-controller/releases/tag/v3.2.0) | expressions | [link](./v3.2.0-report.yaml) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the report link here, along with its rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, missed that one. Thanks :)
11709d1
to
226c967
Compare
226c967
to
426e1e6
Compare
Thanks @czeslavo! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czeslavo, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
/area conformance
What this PR does / why we need it:
Adds a Gateway API v1.1.0 conformance report for Kong's Kubernetes Ingress Controller v3.2.0.
Does this PR introduce a user-facing change?: