-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose GRPC conformance client as in interface #3095
expose GRPC conformance client as in interface #3095
Conversation
Hi @snehachhabria. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: keithmattix, snehachhabria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Let's try this again |
/cherry-pick release-1.1 |
If possible, could this be cherry-picked into release v1.1.0? cc @robscott |
We actually just hadn't created the release-1.1 branch otherwise I think that cherry pick command should have worked. /cherry-pick release-1.1
We'll need to do a patch release, usually we try to accumulate a few things over a couple of weeks so we don't end up with too many patch releases, let's aim for early June? |
@robscott: new pull request created: #3104 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sounds good to me, I am in no hurry we can use the commit from the release branch to unblock us. thanks a lot @robscott and @keithmattix for the quick turn around |
What type of PR is this?
/kind test
/area conformance
What this PR does / why we need it:
The reason for this PR is explained in github issue: #3093
Which issue(s) this PR fixes:
Fixes # #3093
Does this PR introduce a user-facing change?: