Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump the k8s-io group with 3 updates #2599

Closed
wants to merge 1 commit into from
Closed

build(deps): bump the k8s-io group with 3 updates #2599

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 20, 2023 •
edited
Loading

Bumps the k8s-io group with 3 updates: k8s.io/api, k8s.io/apiextensions-apiserver and k8s.io/klog/v2.

Updates k8s.io/api from 0.28.3 to 0.28.4

Commits

Updates k8s.io/apiextensions-apiserver from 0.28.3 to 0.28.4

Commits

Updates k8s.io/klog/v2 from 2.100.1 to 2.110.1

Release notes

Sourced from k8s.io/klog/v2's releases.

Prepare klog release for Kubernetes v1.29 (Take 1)

What's Changed

New Contributors

Full Changelog: kubernetes/klog@v2.100.1...v2.110.1

Commits
  • e3f75b8 Merge pull request #384 from pohly/slog
  • 44eadc3 add slog support
  • cc856bb update to logr 1.3.0
  • 02e7b69 Merge pull request #391 from pohly/with-name-output
  • 009a04a output: handle WithName like zapr does
  • b588475 Merge pull request #380 from pohly/golangci-lint-action
  • 1a0dfc5 github: run golangci-lint via action
  • ef25537 fix revive issues
  • edee20c Merge pull request #392 from pohly/promote-experimental
  • 18cdd3a promote experimental code to stable
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 20, 2023
@dependabot dependabot bot mentioned this pull request Nov 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2023
@dependabot dependabot bot mentioned this pull request Nov 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@robscott
Copy link
Member

/retest
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@robscott
Copy link
Member

Looks like the go-logr change is what broke this:

/opt/buildhome/.gimme_cache/gopath/pkg/mod/github.com/go-logr/logr@v1.3.0/logr.go:276:51: undefined: any

/unapprove

This was referenced Nov 20, 2023
Closed
Closed
Closed
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s-io-96a8619648 branch from 3d9f51b to f67558f Compare November 27, 2023 04:29
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 27, 2023
shaneutt
shaneutt approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual intervention needed

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@shaneutt
Copy link
Member

/unapprove

@shaneutt shaneutt removed their assignment Nov 27, 2023
@shaneutt shaneutt removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 4, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s-io-96a8619648 branch from f67558f to 2319170 Compare December 4, 2023 04:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@shaneutt
Copy link
Member

shaneutt commented Dec 4, 2023

@dependabot recreate

@dependabot
build(deps): bump the k8s-io group with 3 updates
080e6cf 
Bumps the k8s-io group with 3 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) and [k8s.io/klog/v2](https://github.com/kubernetes/klog).


Updates `k8s.io/api` from 0.28.3 to 0.28.4
- [Commits](kubernetes/api@v0.28.3...v0.28.4)

Updates `k8s.io/apiextensions-apiserver` from 0.28.3 to 0.28.4
- [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases)
- [Commits](kubernetes/apiextensions-apiserver@v0.28.3...v0.28.4)

Updates `k8s.io/klog/v2` from 2.100.1 to 2.110.1
- [Release notes](https://github.com/kubernetes/klog/releases)
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md)
- [Commits](kubernetes/klog@v2.100.1...v2.110.1)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-io
- dependency-name: k8s.io/apiextensions-apiserver
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-io
- dependency-name: k8s.io/klog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-io
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s-io-96a8619648 branch from 2319170 to 080e6cf Compare December 4, 2023 13:22
@k8s-ci-robot
Copy link
Contributor

@dependabot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-test 080e6cf link true /test pull-gateway-api-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shaneutt shaneutt self-requested a review December 4, 2023 13:34
@shaneutt shaneutt mentioned this pull request Dec 4, 2023
Closed
@shaneutt
Copy link
Member

shaneutt commented Dec 4, 2023

Created #2642 for this instead, as it's one of our rare opportunities for a newcomer to contribute who knows Golang but maybe not any specific Gateway API implementation and wants to contribute to the project.

@shaneutt shaneutt closed this Dec 4, 2023
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 4, 2023

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

@dependabot dependabot bot deleted the dependabot/go_modules/k8s-io-96a8619648 branch December 4, 2023 17:28
@arukiidou arukiidou mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. go Pull requests that update Go code ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k8s-ci-robot @robscott @shaneutt