Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: introduce mode and sni to cert matching behavior #256

Merged
merged 1 commit into from
Sep 9, 2020
Merged

tls: introduce mode and sni to cert matching behavior #256

merged 1 commit into from
Sep 9, 2020

Conversation

hbagdi
Copy link
Contributor

@hbagdi hbagdi commented Aug 7, 2020

This patch adds a mode property to TLSConfig which determines the TLS
behavior for each listener.

This patch implements one part of the TLSConfig proposal.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 7, 2020
robscott
robscott reviewed Aug 12, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

apis/v1alpha1/gateway_types.go Outdated
// - "Exact": Certificate should be used for the domain only.
// - "Any": Certificate in TLSConfig is the default certificate to use.
//
// The GatewayClass must use the most specific available certificate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GatewayClass be Gateway or implementation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We follow GatewayClass in a lot of places and that's what I borrowed from here. Should I change it in this case or keep as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specific use feels more tied to implementation than class, but this does not need to block the PR.

apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/tlsconfig_types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Aug 12, 2020

Resolved the two comments. PTAL.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@robscott robscott mentioned this pull request Aug 13, 2020
Closed
@danehans
Copy link
Contributor

xref to add backend reencrypt mode at the xRoute level: https://github.com/kubernetes-sigs/service-apis/pull/81/files.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2020
@jpeach jpeach mentioned this pull request Aug 19, 2020
Closed
robscott
robscott reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/tlsconfig_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/tlsconfig_types.go Show resolved Hide resolved
jpeach
jpeach reviewed Aug 19, 2020
View reviewed changes
apis/v1alpha1/tlsconfig_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/tlsconfig_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/gateway_types.go Outdated Show resolved Hide resolved
@hbagdi hbagdi force-pushed the feat/tls branch 2 times, most recently from ef8c622 to 5b24e26 Compare August 21, 2020 00:47
@robscott robscott added this to the v1alpha1 milestone Aug 25, 2020
@robscott
Copy link
Member

Thanks for your work on this! This LGTM but will hold for final approval from @jpeach since there's still one thread open.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Aug 29, 2020

@robscott Rebased, can you take another look?
/assign @robscott

@robscott
Copy link
Member

/lgtm
/hold cancel
/assign @bowei

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 31, 2020
@robscott robscott mentioned this pull request Sep 1, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 1, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Sep 1, 2020

Rebased again to resolve the conflict.
ping @bowei

@robscott
Copy link
Member

robscott commented Sep 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@hbagdi hbagdi mentioned this pull request Sep 3, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2020
@robscott
Copy link
Member

robscott commented Sep 8, 2020

@hbagdi this still LGTM, just needs a rebase.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbagdi, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@hbagdi
tls: introduce mode and sni to cert matching behavior
9c8392b 
This patch adds a `mode` property to TLSConfig which determines the TLS
behavior for each listener.
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 9, 2020
@hbagdi
Copy link
Contributor Author

hbagdi commented Sep 9, 2020

Rebase again. @robscott

@robscott
Copy link
Member

robscott commented Sep 9, 2020

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7c63751 into kubernetes-sigs:master Sep 9, 2020
@hbagdi hbagdi deleted the feat/tls branch September 9, 2020 04:28
@hbagdi hbagdi mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach left review comments

@robscott robscott robscott left review comments

@danehans danehans danehans left review comments

@Miciah Miciah Miciah left review comments

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@robscott robscott

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging this pull request may close these issues.
7 participants
@hbagdi @danehans @robscott @k8s-ci-robot @jpeach @Miciah @bowei