Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in GatewayWithAttachedRoutes #2535

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix bugs in GatewayWithAttachedRoutes #2535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions conformance/tests/gateway-with-attached-routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
Kind: v1.Kind("HTTPRoute"),
}},
Conditions: []metav1.Condition{
{
Type: string(v1.ListenerConditionAccepted),
Status: metav1.ConditionTrue,
Reason: "", // any reason
},
{
Type: string(v1.ListenerConditionProgrammed),
Status: metav1.ConditionFalse,
Expand All @@ -125,7 +120,7 @@ var GatewayWithAttachedRoutes = suite.ConformanceTest{
hrouteNN := types.NamespacedName{Name: "http-route-4", Namespace: "gateway-conformance-infra"}
notAccepted := metav1.Condition{
Type: string(v1.RouteConditionAccepted),
Status: metav1.ConditionTrue,
Status: metav1.ConditionFalse,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it conflicting with

gateway-api/conformance/tests/httproute-invalid-backendref-nonexistent.go

Line 48 in faba258

gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, suite.Client, suite.TimeoutConfig, suite.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I don't see how an implementation can pass both of these tests.
We have this resource that should be Accepted as @sayboras mentioned that's essentially identical to the resource in the test from this PR that should NOT be Accepted.

Copy link
Contributor

@michaelbeaumont michaelbeaumont Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #2548

Reason: "", // any reason
}
unresolved := metav1.Condition{
Expand Down