don't hardcode go version in update codegen script #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
size/XS
dprotaso
commented
Oct 26, 2023
| @@ -26,7 +26,7 @@ readonly GOMODCACHE="$(go env GOMODCACHE)" | |||
| readonly GO111MODULE="on" | |||
| readonly GOFLAGS="-mod=readonly" | |||
| readonly GOPATH="$(mktemp -d)" | |||
| readonly MIN_REQUIRED_GO_VER="1.20" | |||
| readonly MIN_REQUIRED_GO_VER="$(go list -m -f '{{.GoVersion}}')" | |||
There was a problem hiding this comment.
picks up go version from the go.mod file
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, youngnick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2531
/assign @shaneutt