conformance: fetch Gateway in GatewayMustHaveLatestConditions loop #2203
Conversation
Fetches the Gateway from the client each time through the polling loop in GatewayMustHaveLatestConditions, so updates to the conditions can be observed. Signed-off-by: Steve Kriss <krisss@vmware.com>
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/M
| @@ -55,7 +55,7 @@ var GatewayModifyListeners = suite.ConformanceTest{ | |||
| require.NoErrorf(t, err, "error getting Gateway: %v", err) | |||
|
|
|||
| // verify that the implementation is tracking the most recent resource changes | |||
| kubernetes.GatewayMustHaveLatestConditions(t, s.TimeoutConfig, original) | |||
| kubernetes.GatewayMustHaveLatestConditions(t, s.Client, s.TimeoutConfig, gwNN) | |||
There was a problem hiding this comment.
should we move this after the namespace ready check but before fetching the "original" gateway? (similar for the other tests that have similar logic)
There was a problem hiding this comment.
It looks like original is only being used for spec fields, so shouldn't matter too much one way or another, but I'm fine changing the order for readability.
There was a problem hiding this comment.
yeah good point, the original Generation field shouldnt change since the resource shouldnt be updated from when we create it, so I'll defer to you if you think it makes the code more readable to fetch the Gateway after checking the status
Signed-off-by: Steve Kriss <krisss@vmware.com>
|
Thanks @skriss! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, skriss, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind flake
/area conformance
What this PR does / why we need it:
Fetches the Gateway from the client each time through
the polling loop in GatewayMustHaveLatestConditions,
so updates to the conditions can be observed.
The current code is checking the same object over and
over again.
Which issue(s) this PR fixes:
Updates #1883
Does this PR introduce a user-facing change?: