-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SupportedFeature for port 8080 on Gateway #2184
Add SupportedFeature for port 8080 on Gateway #2184
Conversation
Hi @xtineskim. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -64,6 +64,8 @@ const ( | |||
// | |||
// See: https://github.com/kubernetes-sigs/gateway-api/issues/1780 | |||
SupportGatewayClassObservedGenerationBump SupportedFeature = "GatewayClassObservedGenerationBump" | |||
// This option indicates that the Gateway can also use port 8080 | |||
SupportGatewayPort8080 SupportedFeature = "GatewayPort8080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not 100% sure if it should be added to this section - open to suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xtineskim!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, xtineskim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this? /kind test /area conformance
What this PR does / why we need it:
Conformance tests only use ports 80 and 443 in base manifests. This PR removed the Gateway w/ port 8080 in the base.yaml manifest, adds it to the tests yaml that was using it, and adds a
SupportedFeature
for port 8080Which issue(s) this PR fixes:
Fixes ##2094
Does this PR introduce a user-facing change?: