Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip-tests flag added to conformance CLI #2170

Merged
merged 1 commit into from
Jul 7, 2023
Merged

feat: skip-tests flag added to conformance CLI #2170

merged 1 commit into from
Jul 7, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Jul 7, 2023

What type of PR is this?

/kind feature
/area conformance

What this PR does / why we need it:

The --skip-tests flag has been added to the conformance CLI to enable tests opt-out when using it.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The `--skip-tests` flag has been added to the conformance CLI to enable tests opt-out when using it.

@mlavacca
feat: skip-tests flag added to conformance CLI.
2b17fc7 
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/conformance labels Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
shaneutt
shaneutt approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I do think at some point it would be nice if we were actually validating test names, that problem is a bigger scope and doesn't need to hold up this valuable, incremental improvement. 👍

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit e6849b8 into kubernetes-sigs:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@kflynn kflynn Awaiting requested review from kflynn

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mlavacca @k8s-ci-robot @shaneutt