-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conformance: use distinct resource names for test isolation #2106
conformance: use distinct resource names for test isolation #2106
Conversation
Two conformance tests are currently using the same name for their Gateway resource. This leads to contention when one test is actively deleting its Gateway and the other test is actively modifying it. The second test then attempts to retrieve the Gateway; however, the deletion has completed by that time, causing the second test to fail.
Hi @nathancoleman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
passes with Contour
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nathancoleman!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nathancoleman, robscott, sunjayBhatia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind flake
/area conformance
What this PR does / why we need it:
Two conformance tests are currently using the same name for their Gateway resource. This leads to contention when one test is actively deleting its Gateway and the other test is actively modifying the same Gateway. The second test then attempts to retrieve the Gateway to verify expected conditions; however, the deletion has completed by that time, causing the second test to fail as it can't find the Gateway in question.
The changes in this PR use distinct names for the Gateway in each test so that this contention does not occur. Tests reliably pass with these changes included using the Consul implementation of the Gateway API deployed on GKE.
Before:
After:
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: