Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: use distinct resource names for test isolation #2106

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

nathancoleman
Copy link
Contributor

@nathancoleman nathancoleman commented Jun 9, 2023

What type of PR is this?
/kind bug
/kind flake
/area conformance

What this PR does / why we need it:
Two conformance tests are currently using the same name for their Gateway resource. This leads to contention when one test is actively deleting its Gateway and the other test is actively modifying the same Gateway. The second test then attempts to retrieve the Gateway to verify expected conditions; however, the deletion has completed by that time, causing the second test to fail as it can't find the Gateway in question.

The changes in this PR use distinct names for the Gateway in each test so that this contention does not occur. Tests reliably pass with these changes included using the Consul implementation of the Gateway API deployed on GKE.

$ cd ./conformance && gotest -v -timeout 10m ./ --gateway-class consul-api-gateway

Before:
CleanShot 2023-06-09 at 16 24 08@2x

After:
image

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE

Two conformance tests are currently using the same name for their Gateway resource. This leads to contention when one test is actively deleting its Gateway and the other test is actively modifying it. The second test then attempts to retrieve the Gateway; however, the deletion has completed by that time, causing the second test to fail.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @nathancoleman. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

passes with Contour

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@sunjayBhatia
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nathancoleman!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nathancoleman, robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8afce4e into kubernetes-sigs:main Jun 12, 2023
@nathancoleman nathancoleman deleted the gateway-contention branch June 13, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants