-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add probationary step to Experimental GEP phase #2097
docs: add probationary step to Experimental GEP phase #2097
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt!
87c7db4
to
339ecac
Compare
339ecac
to
b7f24b0
Compare
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a15418c
to
bc544c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaneutt! This LGTM other than a broken link. Will leave some time for someone else to review, but no blockers from me.
/cc @arkodg @kflynn @sunjayBhatia @youngnick
/approve
bc544c5
to
be38280
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two nits that are not meant to be blocking -- thanks for putting this together, @shaneutt, looks good! 🙂
23087fc
to
eeffc54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's maybe talk about a recommended time later -- ship it!! 🙂
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh I'm sorry, I added a recommended time of 6 months did I stomp all over? Take a look at the new recommended time that's in there, and comment whether that meets your criteria or whether you think there's more to do here? /hold |
@shaneutt uhhhh yeah, turns out I just couldn't read or something. 🤦♂️ Hit it!! Looks good from here. 🙂 /lgtm |
Ok, no worries thank you! /unhold |
What type of PR is this?
/kind documentation
/kind gep
What this PR does / why we need it:
To better imitate upstream Kubernetes, we need to enact "probationary periods" for GEPs during the
Experimental
phase.This will help us:
Experimental
phase without forward momentumExperimental
features may be removed in future releasesAdditionally this removes our old "quick start" section of the enhancement page on the website in favor of a "how to", the main reason for this being we want to consult with community members before GEPs are created so that we can help contributors avoid frustration and pitfalls.