Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add probationary step to Experimental GEP phase #2097

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

shaneutt
Copy link
Member

@shaneutt shaneutt commented Jun 6, 2023

What type of PR is this?

/kind documentation
/kind gep

What this PR does / why we need it:

To better imitate upstream Kubernetes, we need to enact "probationary periods" for GEPs during the Experimental phase.

This will help us:

  • avoid GEPs spending inordinately long times in the Experimental phase without forward momentum
  • better establish and enforce graduation criteria for GEPs
  • better indicate to implementations that unfinished Experimental features may be removed in future releases

Additionally this removes our old "quick start" section of the enhancement page on the website in favor of a "how to", the main reason for this being we want to consult with community members before GEPs are created so that we can help contributors avoid frustration and pitfalls.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2023
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 6, 2023
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt!

geps/overview.md Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
@shaneutt shaneutt requested a review from robscott June 6, 2023 21:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2023
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 8, 2023
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
geps/overview.md Outdated Show resolved Hide resolved
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shaneutt! This LGTM other than a broken link. Will leave some time for someone else to review, but no blockers from me.

/cc @arkodg @kflynn @sunjayBhatia @youngnick
/approve

geps/gep-957.md Outdated Show resolved Hide resolved
@shaneutt shaneutt requested a review from robscott June 9, 2023 18:42
@shaneutt shaneutt removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 9, 2023
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two nits that are not meant to be blocking -- thanks for putting this together, @shaneutt, looks good! 🙂

geps/overview.md Show resolved Hide resolved
geps/overview.md Show resolved Hide resolved
@shaneutt shaneutt requested a review from kflynn June 9, 2023 18:47
@shaneutt shaneutt force-pushed the shaneutt/gep-probation branch 2 times, most recently from 23087fc to eeffc54 Compare June 9, 2023 18:53
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's maybe talk about a recommended time later -- ship it!! 🙂

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kflynn, robscott, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaneutt
Copy link
Member Author

shaneutt commented Jun 9, 2023

OK, let's maybe talk about a recommended time later -- ship it!! slightly_smiling_face

Oh I'm sorry, I added a recommended time of 6 months did I stomp all over? Take a look at the new recommended time that's in there, and comment whether that meets your criteria or whether you think there's more to do here?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2023
@kflynn
Copy link
Contributor

kflynn commented Jun 9, 2023

@shaneutt uhhhh yeah, turns out I just couldn't read or something. 🤦‍♂️ Hit it!! Looks good from here. 🙂

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@shaneutt
Copy link
Member Author

shaneutt commented Jun 9, 2023

Ok, no worries thank you!

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit f2cd9bb into kubernetes-sigs:main Jun 9, 2023
@shaneutt shaneutt deleted the shaneutt/gep-probation branch June 9, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants